p4lang / p4-applications

P4 Applications WG repo
107 stars 46 forks source link

INT-MX 'source-only' metadata embedded by source and reported by each node #83

Closed mickeyspiegel closed 4 years ago

mickeyspiegel commented 4 years ago
mickeyspiegel commented 4 years ago

The first two commits are reorganization of existing text. The third commit contains the technical changes.

mickeyspiegel commented 4 years ago

There are lots of tricky details regarding unknown Domain Specific ID and backwards compatibility implications. Pay attention when reviewing.

mickeyspiegel commented 4 years ago

After splitting the two main options for INT-MX transit node processing, there is a question whether the second option with padding is too complicated. Should it be deleted?

jklr commented 4 years ago

Thanks Mickey. I will review. I vote for deleting the second option with padding, for the sake of simplicity.

jklr commented 4 years ago

If we remove option #2, we can remove HopML from the MX header.

Q1. Can we also remove E and M bits and make them all reserved? Q2. how about adding 24b SEQ# in the freed-up space? SEQ# seems commonly needed by edge-to-edge and also some congestion control use cases.

mickeyspiegel commented 4 years ago

@jklr We can remove HopML if it is no longer used when forming Telemetry Reports.

I believe @rsivakolundu wanted to keep the E and M bit definitions when I asked a while ago.

I don't believe seq # should always be there. It makes sense from NICs, but it is difficult for switches to insert. With all the changes to allow source-only metadata, that seems like a perfect place for seq # to go.

rsivakolundu commented 4 years ago

I am ok with removing E and M bit and HOP-ML field and making all of them reserved. Cannot deal with using those reserved fields for anything at this stage.

jklr commented 4 years ago

sure. Let's remove E, M and HopML and keep them all as reserved bits.

mickeyspiegel commented 4 years ago

@jklr I threw an INT-MX with domain specific source-only metadata consisting of a Flow ID and Sequence Number into a separate example at the end. I also moved the INT-MD domain specific source-only example from Randy to the end of the Examples section instead of being stuck in an appendix.

mickeyspiegel commented 4 years ago

I will open a new PR for removing option #2 (padding), HopML, E, M, which will touch Telemetry Report as well as INT.