p4lang / p4analyzer

A Language Server Protocol (LSP) compliant analyzer for the P4 language
Apache License 2.0
19 stars 3 forks source link

Refactored `stdio.rs` and `stdout` capturing #20

Closed AndrewF001 closed 1 year ago

AndrewF001 commented 1 year ago

Hi All!

I would appreciate feedback on the enum approach I've taken for implementing different sources to the driver! This new approach dealt with all the issues that came with stdout capture and having a working unit test to show it in action.

Changes:

Thanks for the review!