search

p4lang / p4c

P4_16 reference compiler
https://p4.org/
Apache License 2.0
677 stars 444 forks source link

Rename v1model-newtype.pp to v1model-newtype.p4 and add expected output files? #3593

Open jafingerhut opened 2 years ago

jafingerhut commented 2 years ago

testdata/p4_16_samples/v1model-newtype.pp has no expected output files, and since it has a .pp suffix I believe that the auto-run tests never do anything with it. Keep it? If so, seems best to rename it to end with .p4 and then add expected output files for it.

jafingerhut commented 2 years ago

Hmmm. This .pp file appears like it was #include'd by another P4 test program at some point in the past, one named psa-portid-using-newtype2.p4. That file was renamed v1model-portid-using-newtype2.p4, but accidentally (I think) put into the root directory of this repo, then later that file was removed, so now there is no file that #include's v1model-newtype.pp.

@jafingerhut I should probably think about what to do with all of the files containing 'portid-using-newtype' in their names, together with v1model-newtype.pp. I'm not sure what the best way to handle them is, yet, but they should have the same fate.