search

p4lang / p4c

P4_16 reference compiler
https://p4.org/
Apache License 2.0
683 stars 446 forks source link

[P4Tools] Clean up use of ::P4 prefix for errors, warnings, and logs. #4930

Closed fruffy closed 1 month ago

fruffy commented 2 months ago

Unclear why p4c-lint is failing. The formatter makes no changes locally...

vlstill commented 2 months ago

Unclear why p4c-lint is failing. The formatter makes no changes locally...

Maybe mismatch in clang-format version or some problem with local config? The CI log shows the errors and they make sense to me.

fruffy commented 2 months ago

Maybe mismatch in clang-format version or some problem with local config? The CI log shows the errors and they make sense to me.

I made sure the clang-format versions are the same. Maybe it doesn't pick up the config correctly.

fruffy commented 2 months ago

Maybe mismatch in clang-format version or some problem with local config? The CI log shows the errors and they make sense to me.

I made sure the clang-format versions are the same. Maybe it doesn't pick up the config correctly.

The problem was that the branch was opened from a different repository... Should be fixed now.