search

p4lang / p4c

P4_16 reference compiler
https://p4.org/
Apache License 2.0
683 stars 446 forks source link

set PathExpression type in ExpandLookahead #4959

Closed grg closed 1 month ago

grg commented 1 month ago

Don't leave the PathExpression as Type_Unknown when expanding a lookahead.

Fixes an issue I hit in Tofino code where an expanded lookahead triggers a failure in another pass because width_bits() is called on a Type_Unknown object.

grg commented 1 month ago

@fruffy The test-p4c-fedora job has failed twice on this PR, both times with the same error:

sudo: PAM account management error: Authentication service cannot retrieve authentication info
sudo: a password is required

Any idea what's going on here?

fruffy commented 1 month ago

@fruffy The test-p4c-fedora job has failed twice on this PR, both times with the same error:

sudo: PAM account management error: Authentication service cannot retrieve authentication info
sudo: a password is required

Any idea what's going on here?

Yeah it seems permissions have changed, #4957 has a fix. You can ignore these failures.