p4lang / p4c

P4_16 reference compiler
https://p4.org/
Apache License 2.0
681 stars 444 forks source link

Small TC fixes #5002

Closed vbnogueira closed 1 week ago

vbnogueira commented 2 weeks ago

Whilst writing the automated test tools for the tc backend, I ended up finding some compilation bugs when compiling some generated C files from the testdata samples directory This PR fixes those issues, describes them in more detail in the commit messages and updates pna.h

vbnogueira commented 2 weeks ago

@komaljai please take a look when you have some time

vbnogueira commented 1 week ago

@fruffy question: Do we need to wait for the tofino fix to merge this PR, or can we merge as is?

fruffy commented 1 week ago

You can merge as is. The Tofino back end fixes will take a while.

vbnogueira commented 1 week ago

You can merge as is. The Tofino back end fixes will take a while.

Sorry, but can you merge it? I would merge myself, but I don't have permission to do so