search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
144 stars 88 forks source link

Add the ability to use @id for action params, table keys and packetio headers #272

Closed stefanheule closed 4 years ago

stefanheule commented 4 years ago

This is as proposed in #268, but also adding it for packetio headers, which seems natural.

antoninbas commented 4 years ago

@stefanheule please fix the conflict so we can merge

stefanheule commented 4 years ago

@stefanheule please fix the conflict so we can merge

Done.

antoninbas commented 4 years ago

@stefanheule the diff shows that you have made the files you modified executable by changing their access permissions from 644 to 755. Could you revert that?

The diff also shows your earlier "metadata" changes for some reason, which we already have merged in master. This should not be a big deal when we merge, but you may want to git fetch --all && git rebase origin/master before pushing again.

stefanheule commented 4 years ago

Fixed, I think. Sorry for the mishap.