search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
146 stars 89 forks source link

Fix Bazel build rules, addressing #250 #297

Closed smolkaj closed 4 years ago

smolkaj commented 4 years ago

Also add CI to prevent future breakage and update the BAZEL_NOTES. Add '.bazel' suffixes to Bazel files to be respectful to people unfamiliar with Bazel.

smolkaj commented 4 years ago

@antoninbas @pudelkoM @stefanheule

smolkaj commented 4 years ago

By the way, the new Github action that builds the protobufs using Bazel only takes 35 seconds. :)

smolkaj commented 4 years ago

I added an example Bazel project depending on P4Runtime in bazel/example.

smolkaj commented 4 years ago

Thanks for the feedback, @pudelkoM. Could you take another look if this looks good?

pudelkoM commented 4 years ago

Thanks for the feedback, @pudelkoM. Could you take another look if this looks good?

I have started a PR against these changes, let's see if it works directly.

smolkaj commented 4 years ago

Thanks for the feedback, @pudelkoM. Could you take another look if this looks good?

I have started a PR against these changes, let's see if it works directly.

Awesome, sounds good.

smolkaj commented 4 years ago

Thanks for the feedback, @antoninbas! Fixed the typos.