Closed stefanheule closed 4 years ago
LGTM. Could you resolve the merge conflict and address the CI error?
It appears the build fails with a go problem? Any idea what is wrong? I didn't touch that at all. https://travis-ci.com/github/p4lang/p4runtime/builds/189092852
From the CI logs:
The generated Go files are not up-to-date You can regenerate them with './codegen/update_go.sh' and commit the changes
From the CI logs:
The generated Go files are not up-to-date You can regenerate them with './codegen/update_go.sh' and commit the changes
Oops, sorry, the fact that this was talking about go and I didn't change any go threw me off. But now I understand. Fixed.
The diff is showing changes from earlier PRs, could you rebase? I want to make sure I merge the right thing
The diff is showing changes from earlier PRs, could you rebase? I want to make sure I merge the right thing
Done.
Fixes https://github.com/p4lang/p4runtime/issues/307