search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
146 stars 89 forks source link

Deprecate watch in favor of watch_port. #317

Closed stefanheule closed 4 years ago

stefanheule commented 4 years ago

Fixes https://github.com/p4lang/p4runtime/issues/307

stefanheule commented 4 years ago

LGTM. Could you resolve the merge conflict and address the CI error?

It appears the build fails with a go problem? Any idea what is wrong? I didn't touch that at all. https://travis-ci.com/github/p4lang/p4runtime/builds/189092852

antoninbas commented 4 years ago

From the CI logs:

The generated Go files are not up-to-date You can regenerate them with './codegen/update_go.sh' and commit the changes

stefanheule commented 4 years ago

From the CI logs:

The generated Go files are not up-to-date You can regenerate them with './codegen/update_go.sh' and commit the changes

Oops, sorry, the fact that this was talking about go and I didn't change any go threw me off. But now I understand. Fixed.

antoninbas commented 4 years ago

The diff is showing changes from earlier PRs, could you rebase? I want to make sure I merge the right thing

stefanheule commented 4 years ago

The diff is showing changes from earlier PRs, could you rebase? I want to make sure I merge the right thing

Done.