search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
144 stars 88 forks source link

Clarify spec: annotation locations are optional. #326

Closed smolkaj closed 3 years ago

smolkaj commented 3 years ago

Fixes #311.

smolkaj commented 3 years ago

@antoninbas Can you remind me how to update all generated files?

antoninbas commented 3 years ago

@antoninbas Can you remind me how to update all generated files?

It's documented at the end of the README

When updating the Protobuf files in a pull request, you will also need to update the generated Go files, which are hosted in this repository under go/. This can be done easily by running ./build/update_go.sh, providing docker is installed and your user is part of the "docker" group (which means that the docker command can be executed without sudo).

smolkaj commented 3 years ago

Thanks, done.