search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
144 stars 88 forks source link

Deprecate egress_port (uint32) in favor of egress (bytes) in Replica #331

Closed antoninbas closed 1 year ago

antoninbas commented 3 years ago

This is to ensure consistency with the watch_port field. See https://github.com/p4lang/p4runtime/pull/317

Fixes #329

onf-cla-manager[bot] commented 3 years ago

Hi @antoninbas, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID antoninbas to the agreement.

For more information or help:" https://wiki.opennetworking.org/x/BgCUI

smolkaj commented 1 year ago

Bump. We are starting to use multicast. Would be great to get this submitted.

antoninbas commented 1 year ago

Bump. We are starting to use multicast. Would be great to get this submitted.

I don't mind merging this as it is. I know that other parts of the spec also needs to be tackled: the Index message, used to address Counter and Meter entries, should also support translation and its type should be changed to bytes (indexing a counter using a port value is a pretty common scenario). However, that can be done in a future PR.

antoninbas commented 1 year ago

@smolkaj I rebased the PR, could you take a look?