search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
142 stars 88 forks source link

Add support for string roles & roles in reads #346

Closed konne88 closed 3 years ago

konne88 commented 3 years ago

This addresses bugs: https://github.com/p4lang/p4runtime/issues/344 https://github.com/p4lang/p4runtime/issues/345

konne88 commented 3 years ago

Antonin, I just got the tests to pass. Can you review. Thanks!

konne88 commented 3 years ago

I squashed the commits.

antoninbas commented 3 years ago

@konne-google you have merged conflicts, as I had to merge a separate PR

konne88 commented 3 years ago

@antoninbas , I don't think I can merge the request (The base branch restricts merging to authorized users.), could you do it for me? There is still a failing test, but I don't think I can fix it, it says:

docker: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.

antoninbas commented 3 years ago

@konne88 I restarted the job, I'll merge when it passes