Add Go proto build rule for p4info

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API

Apache License 2.0

142 stars 88 forks source link

Add Go proto build rule for p4info #351

Closed sthesayi closed 3 years ago

sthesayi commented 3 years ago

This PR adds a build rule for the p4info.proto to generate the Go library version.

antoninbas commented 3 years ago

The PR itself looks good to me, but the build is failing: ERROR: /home/runner/work/p4runtime/p4runtime/proto/BUILD.bazel:63:1: name 'go_proto_library' is not defined (did you mean 'cc_proto_library'?)

Please also take a look at the CLA

sthesayi commented 3 years ago

I believe to have fixed the build issue. Sorry for the premature request as it was my first CL and I forgot to mark it as draft. I am not sure why it still says "Waiting for status to be reported" but the CL build is passing now. I also fixed the CLA issue.

sthesayi commented 3 years ago

Undo LGTM, look like we need additional changes to make things build.

This is good for second review. Thanks