p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
142 stars 88 forks source link

Add Go proto build rule for p4runtime #359

Closed akarshgupta25 closed 3 years ago

akarshgupta25 commented 3 years ago

This PR adds go_proto_library rule for p4runtime.proto in BUILD file.

smolkaj commented 3 years ago

@antoninbas, could you take a look? I believe this should be an uncontroversial change that is just adding a missing BUILD target.

antoninbas commented 3 years ago

@akarshgupta25 the Github workflow which checks the bazel build is failing

akarshgupta25 commented 3 years ago

I am unable to trigger a rebuild on Travis CI. @antoninbas is there a way I can trigger the build to verify the new changes?

smolkaj commented 3 years ago

@antoninbas I believe this is ready to be merged?

smolkaj commented 3 years ago

That was fast, thank you! :)