search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
142 stars 88 forks source link

Updates Master Arbitration Updates to clarify that (device_id, role, election_id) triples are only unique for live controllers. #368

Closed jonathan-dilorenzo closed 2 years ago

jonathan-dilorenzo commented 2 years ago

See issue #365 for more details. I also made some minor language (and formatting?) improvements.

Is it possible to somehow see how this is going to render?

antoninbas commented 2 years ago

@jonathan-dilorenzo you can render the documents locally to validate formatting, or you can open PRs directly from this repo instead of using a fork (I will give you write access). When opening a PR from a branch instead of from a fork, the docs are rendered and uploaded to S3, where you can check them before merging: https://github.com/p4lang/p4runtime/tree/main/docs#ci-upload-of-built-documents

jonathan-dilorenzo commented 2 years ago

Fantastic. Thanks so much @antoninbas. I will try opening a PR from a branch of this repo then. Sadly, the local rendering seems to require utilities that I cannot install on my work computer (without relatively significant research at least).

jonathan-dilorenzo commented 2 years ago

Closing to move to #387.