Open smolkaj opened 2 years ago
We still want something like this eventually, but we aren't currently actively working on it.
I think we'd also want to add a semi-static & semi-dynamic mapping.
@antoninbas any thoughts on whether it would be more or less preferable to add this as a separate RPC?
I think we'd also want to add a semi-static & semi-dynamic mapping.
@antoninbas any thoughts on whether it would be more or less preferable to add this as a separate RPC?
In my mind, it was going to be decoupled from the ForwardingPipelineConfig
: even if a new P4 pipeline was pushed, the mapping would typically remain the same as it would be specific to the switch hardware (and the P4 architecture) and not to the P4 program.
I am also not clear about how the dynamic mapping would work. Your comment in the Protobuf implies that the switch / server would be responsible for allocating "P4 values", which does not match my current understanding.
It's probably something worth discussing at the next WG meeting. I doubt I have the most comprehensive perspective on this.
In my mind, it was going to be decoupled from the ForwardingPipelineConfig: even if a new P4 pipeline was pushed, the mapping would typically remain the same as it would be specific to the switch hardware (and the P4 architecture) and not to the P4 program.
Makes sense, I agree.
I am also not clear about how the dynamic mapping would work. Your comment in the Protobuf implies that the switch / server would be responsible for allocating "P4 values", which does not match my current understanding.
That's right. This is meant as a convenience. Consider the following use case:
table 1 (route lookup): matches on dst IP and sets a "route ID" (some user metadata field) table 2 (route execution): matches on "route ID" and sets the egress port/src mac/dst mac appropriately.
Maybe in our SDN controller, we want to give these routes semantically meaningful names, so we define
@p4runtime_translation("", string)
type bit<10> route_id_t;
Now we can program routes as follows:
Table 1:
Table 2:
Internally, the switch will map the route IDs to bit<10>
. It may use the mapping
"internal VM route" <-> 1
"default" <-> 2
Or, it could use
"internal VM route" <-> 2
"default" <-> 1
Or it could use any other bijection between strings and bit<10>
. The interesting observation is that it doesn't matter which mapping the switch uses, since there will be no observable difference from the controller (as long as the mapping is a bijection):
Since the mapping is irrelevant, it would be very convenient if we didn't have to specify it explicitly.
@smolkaj thanks for the reminder. I think we discussed this before, but I was very much focused on the special case of port translation.
When we added the p4runtime_translation
annotation, I don't think we considered the "dynamic" case. I also think we were focused on the case where the annotated type is defined as part of the architecture.
I believe that both cases ("static" and "dynamic") can be supported using a separate RPC. As you pointed out, the only guarantee for the "dynamic" case is that the mapping is a bijection. The underlying values can stay the same or be re-generated when a new ForwardingPipelineConfig
is sent to the switch (implementation-dependent), even for a RECONCILE_AND_COMMIT
.
With a separate RPC however, there are a few open questions:
ForwardingPipelineConfig
has been sent to the switch and table entries have been inserted?With your current proposal, things become easier (the second question does not exist), but static mappings have to be included for each ForwardingPipelineConfig
. The port translation mapping has to be provided by the P4Runtime controller, which may not be an issue for you.
RE dynamic mappings: For better or worse, we started using them in SONIC/PINS. I am starting to wonder if that was a mistake, as explaining them to people is rather tricky, and so is reasoning about their correctness. At further thought, I think it might be a mistake to standardize them, and perhaps instead we should stop using them. Either way, perhaps it would be best to not include them for the initial proposal, we could always revisit that later.
- what happens if there is no available mapping data (mapping was not defined, or a value is missing in a static mapping)?
I guess we should return a FAILED_PRECONDITION
error in that case?
https://grpc.github.io/grpc/core/md_doc_statuscodes.html
- can the mapping data be updated dynamically after a ForwardingPipelineConfig has been sent to the switch and table entries have been inserted?
This is a trickier one. In SONIC/PINS, for ports, we decided that no, this is not legal. But it is not entirely trivial to implement. More precisely, it is illegal if there is an entry using the port for which the mapping is being changed.
@smolkaj is this still in play?