search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
142 stars 88 forks source link

Build Python distribution before pushing to PyPI #380

Closed antoninbas closed 2 years ago

antoninbas commented 2 years ago

The pypa/gh-action-pypi-publish action doesn't take care of building the distribution. See https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

onf-cla-manager[bot] commented 2 years ago

Hi @antoninbas, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID antoninbas to the agreement.

For more information or help:" https://wiki.opennetworking.org/x/BgCUI

antoninbas commented 2 years ago

@Yi-Tseng does this look correct to you?