search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
140 stars 86 forks source link

Fix bazel version to 5.4.0 #409

Closed smolkaj closed 1 year ago

smolkaj commented 1 year ago

This is to work around breaking changes introduced by Bazel 6: bazelbuild/bazel#8622 (comment)

We can wait until the next nightly CI to see if we're actually affected, and only merge this if that's the case.

antoninbas commented 1 year ago

@stefanheule don't we usually try to support the latest version of Bazel? Can't we follow the "Migration" steps described in the issue you referenced?

stefanheule commented 1 year ago

Assuming this is meant for @smolkaj, not me? I'm no longer working on P4RT.

antoninbas commented 1 year ago

@stefanheule yes, apologies. I typed @stef and selected the first result without thinking :). I'll remove you from the repo.

smolkaj commented 1 year ago

Why not a guest appearance @stefanheule? ;)

smolkaj commented 1 year ago

Yes @antoninbas, +1, I think we should generally try to keep up to date with the latest Bazel version.

In this case, I (i) didn't have the time to dig sufficiently deeper and (ii) suspect this is an issue caused by upstream dependencies. With a bit of luck, if we wait a couple of weeks, our upstream dependencies may have made the necessary changes, and we can then upgrade to their latest versions and undo my change.

So this is just meant as a temporary workaround, given that I will be OOO for a while.