p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
144 stars 88 forks source link

Clarify the distinction of unset scalar fields vs unset message fields. #418

Closed smolkaj closed 1 year ago

smolkaj commented 1 year ago

There is a subtle distinction between the treatment of default-valued message fields vs default-valued scalar fields. This has bitten me and others at Google one to many times, so this PR clarifies the distinction.

This PR is not intended to introduce any semantic changes.

antoninbas commented 1 year ago

let's hold off on merging this, I think @jafingerhut wanted to take a look over the weekend

smolkaj commented 1 year ago

Sounds great, no rush. Thanks everyone for the reviews!

jafingerhut commented 1 year ago

As of commit 6 on this PR, I see all "master" occurrences replaced with "primary", so looks ready to go to me.

smolkaj commented 1 year ago

Thanks!