search

p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
140 stars 86 forks source link

Update generic-table-dev with dev branch workflows #442

Closed saynb closed 11 months ago

saynb commented 11 months ago

Dummy PR to just check whether the changes work on the dev branch. Will be creating a PR for main branch for this change instead

chrispsommers commented 11 months ago

Hi @saynb did you need someone to approve this for test purposes?

saynb commented 11 months ago

Hi @saynb did you need someone to approve this for test purposes?

Hi @chrispsommers , I am still making changes on this and trying out what works and what doesn't with the CI. It will be probably a few tried before it is ready for review and so I converted it to draft. I think CI is able to run even without approvals. If this change goes in this dev branch, that would be good enough for testing. Would you prefer we make this change only in dev branch or test it here and make the change in main instead? Either way works. In the second method

  1. Test here
  2. Raise PR against main and push in
  3. Raise PR against this branch to sync with main
chrispsommers commented 11 months ago

Hi @saynb Do you need any actions/decisions to move this forward? Regarding:

Would you prefer we make this change only in dev branch or test it here and make the change in main instead

I don't think it matters much either way, but I am in favor of pushing the CI/CD rules changes to main then syncing back to -dev. That way all future -dev branches will gain the benefits if they branch off main. You'd need to make a new PR of course, this one has catchup-commits from main.

Did you test this to your satisfaction?

saynb commented 11 months ago

Closing this since have tested this enough and have raised https://github.com/p4lang/p4runtime/pull/443. @chrispsommers FYI