p4lang / p4runtime

Specification documents for the P4Runtime control-plane API
Apache License 2.0
140 stars 86 forks source link

Changes for language spec update? Clarified the restrictions on run time for tables with const entries #453

Closed jafingerhut closed 5 months ago

jafingerhut commented 10 months ago

This issue is related to the following change made from v1.2.3 to v1.2.4 of the P4_16 language specification:

This paragraph is edited from version 1.2.3 to 1.2.4 of the language spec, and the emphasized text is new:

Table entries defined using const entries are immutable—i.e., they can only be read by the control plane. The control plane is not allowed to remove or modify any entries defined within const entries, nor is it allowed to add entries to such a table. It is allowed for individual entries to have the const keyword before them, but this is redundant when the entries are declared using const entries.

(see https://p4.org/p4-spec/docs/P4-16-v1.2.4.html#sec-summary-of-changes-made-in-version-124 for the item in context of the full list of changes, but there are separate Github issues for each that might impact the P4Runtime API specification).

I believe this is only a clarification of what existing implementations did, but good to discuss in API work group to make sure.

jafingerhut commented 10 months ago

2023-Sep-08: Decision made that no P4Runtime spec changes needed, so remove this item from bullet list in spec. Already explicitly stated in the P4Runtime spec.

jafingerhut commented 10 months ago

This issue can be closed if/when PR https://github.com/p4lang/p4runtime/pull/459 is merged.

jafingerhut commented 5 months ago

PR #459 was merged, so closing this as resolved.