search

p4lang / pna

Portable NIC Architecture
Apache License 2.0
55 stars 22 forks source link

Name changes in pna.p4 #101

Closed mariobaldi closed 1 year ago

mariobaldi commented 1 year ago

Names changed in pna.p4 to reflect the removal of pre-control.

onf-cla-manager[bot] commented 1 year ago

Hi @mariobaldi, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID mariobaldi to the agreement.

For more information or help:" https://wiki.opennetworking.org/x/BgCUI

mariobaldi commented 1 year ago

I agree that this should go with PR #99, but I thought of keeping them separate in case we agree with changing the architecture (i.e., approve PR #99 and possibly PR#100), but don’t agree with changing the naming convention.

Mario

From: Thomas Calvert @.> Sent: Monday, December 12, 2022 12:41 PM To: p4lang/pna @.> Cc: Mario Baldi @.>; Mention @.> Subject: Re: [p4lang/pna] Name changes in pna.p4 (PR #101)

@thomascalvert-xlnx commented on this pull request.

Makes sense to rationalise the names. Perhaps a single commit changing the names in both the P4 and MDK files would be cleaner, but assuming that both this and #100 https://github.com/p4lang/pna/pull/100 get approved around the same time the result will be the same.

This change does make all the examples inconsistent, so I think a mass rename might be in order?

— Reply to this email directly, view it on GitHub https://github.com/p4lang/pna/pull/101#pullrequestreview-1213364556 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AICNJE62EXMAGTHNH3YJW4LWM4FNJANCNFSM6AAAAAAS24LHQE . You are receiving this because you were mentioned.Message ID: @.***>

mariobaldi commented 1 year ago

Obsolete as we decided not to change the names of the parser, deparser and control blocks