search

p4lang / pna

Portable NIC Architecture
Apache License 2.0
55 stars 21 forks source link

send_to_port and mirror_packet arguments should be in direction #110

Closed apinski-cavium closed 1 year ago

apinski-cavium commented 1 year ago

I noticed this while testing a front-end change for compile time known-constants fix. These arguments should not be directionless and not required to be a compile time known constants.

Signed-off-by: Andrew Pinski apinski@marvell.com

onf-cla-manager[bot] commented 1 year ago

Hi @apinski-cavium, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID apinski-cavium to the agreement.

For more information or help:" https://wiki.opennetworking.org/x/BgCUI

apinski-cavium commented 1 year ago

I should note this was found while implementing https://github.com/p4lang/p4-spec/pull/1213 into a front-end.

apinski-cavium commented 1 year ago

LGTM. Sorry I had not noticed this much earlier!

We all missed it before the release in December. Also the examples only use send_to_port/mirror_packet from an action where the argument was from the table/control plane (and p4c has a bug there which allows it) which allowed this to missed by the examples also. Basically I am saying things slip through everyone's eyes even.