search

p4lang / pna

Portable NIC Architecture
Apache License 2.0
54 stars 21 forks source link

Some cleanup to pna.p4 and one example P4 program since PreControl removed #88

Closed jfingerh closed 1 year ago

jafingerhut commented 1 year ago

Please give a review @thomascalvert-xlnx @mariobaldi - Should be fairly quick and easy. Without these changes, I get error messages from p4test on the P4 programs in the examples directory.

rst0git commented 1 year ago

I get error messages from p4test on the P4 programs in the examples directory.

@jfingerh I have opened a pull request to add GitHub action to run these tests automatically: https://github.com/p4lang/pna/pull/90

The test would fail without the changes in this pull request. Thus, I have rebased my patch on your branch and I can mark the pull request as "ready for review" once the changes in this pull request have been merged.

thomascalvert-xlnx commented 1 year ago

LGTM, thanks Andy for doing this 👍