Closed mariobaldi closed 1 year ago
It appears that PRs #99 and #100 are perhaps the same, or at least very similar? Is one of them considered more up to date, and the other can be closed?
They are not the same.
PR #99 substitutes separate inline externs with one inline accelerator block.
PR #100 unifies the packet flow within the pipeline: i.e., packets coming from different inputs of the pipeline (from network, from host, or recirculated) follow the same flow and can all be routed to any possible “next step” (i.e., to the host, to the network, or being recirculated).
Mario
From: Andy Fingerhut @.> Sent: Monday, December 12, 2022 12:35 PM To: p4lang/pna @.> Cc: Mario Baldi @.>; Mention @.> Subject: Re: [p4lang/pna] Inline accelerators substitute inline externs (PR #99)
It appears that PRs #99 https://github.com/p4lang/pna/pull/99 and #100 https://github.com/p4lang/pna/pull/100 are perhaps the same, or at least very similar? Is one of them considered more up to date, and the other can be closed?
— Reply to this email directly, view it on GitHub https://github.com/p4lang/pna/pull/99#issuecomment-1346323498 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AICNJEYHNDW3DFTKMYEY7MTWM4EWLANCNFSM6AAAAAAS23UJTM . You are receiving this because you were mentioned.Message ID: @.***>
Changes captured by PR #100
Hi @mariobaldi, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:
✒️ 👉 https://cla.opennetworking.org
After signing, make sure to add your Github user ID
mariobaldi
to the agreement.For more information or help:" https://wiki.opennetworking.org/x/BgCUI