Some cleanup to packet library and the testutils

p4lang / ptf

Packet Test Framework

Apache License 2.0

146 stars 99 forks source link

Some cleanup to packet library and the testutils #136

Closed Yi-Tseng closed 3 years ago

Yi-Tseng commented 3 years ago

Scapy 2.4.4 supports VXLAN, ERSPAN, GENEVE, MPLS We can include them from the Scapy directly without installing the p4lang/scapy-vxlan Also some cleanup to the test utility

Missing scapy. for some types (e.g., Dot1Q should be scapy.Dot1Q)
Use int instead of long since they already unified, see EP237

Yi-Tseng commented 3 years ago

You are right, actually, it won't work since the scapy-vxlan is too old (v2.2.0).
Do you think it is reasonable to update the scapy-vxlan to the latest version of Scapy and add the NVGRE support? Or we can just add the NVGRE class to packet.py and we can deprecate the scapy-vxlan repo?

antoninbas commented 3 years ago

You are right, actually, it won't work since the scapy-vxlan is too old (v2.2.0). Do you think it is reasonable to update the scapy-vxlan to the latest version of Scapy and add the NVGRE support? Or we can just add the NVGRE class to packet.py and we can deprecate the scapy-vxlan repo?

Deprecating scapy-vxlan sounds good to me. I believe we are currently in violation of the scapy license, so it is long overdue.

antoninbas commented 3 years ago

No news from @saynb, so let's ping @slicking :)