search

p4lang / ptf

Packet Test Framework
Apache License 2.0
144 stars 99 forks source link

Fix #108: Change how EventDescriptor objects are cleaned up to avoid exception #181

Closed jafingerhut closed 1 year ago

jafingerhut commented 1 year ago

It is not clear to me why "some checks were not successful" on the CI run triggered by creating this PR.

antoninbas commented 1 year ago

@jafingerhut the PR looks fine. CI is failing because the workflow definition file is stale. I am working on a PR to fix it: https://github.com/p4lang/ptf/pull/182. When it is merged, please rebase your own PR.

antoninbas commented 1 year ago

@jafingerhut I merged my PR and I directly updated your branch using the Github UI. I will merge as soon as CI tests pass.