p4lang / tdi

Table-Driven Interface (TDI) for a P4-programmable backend device.
Apache License 2.0
40 stars 23 forks source link

Parenthesis "()" in key field name is not properly handled in tdicli.py #131

Open nithas-ns opened 1 year ago

nithas-ns commented 1 year ago

At line number https://github.com/p4lang/tdi/blob/22cb07ac887491450d2efdb65cca727f99ecd317/tdi_python/tdicli.py#L1103 few of the special characters in key name is replaced with appropriate characters such that tdi cli does not throw error (i.e., These key names are used as python method argument identifiers, python identifiers has to be alpha numeric and it cannot contain special characters). When referred to p4 spec, "isValid()" is also an allowed key name, so this key also has to be handled properly (i.e., replacement for "()")