p4lang / tutorials

P4 language tutorials
Apache License 2.0
1.33k stars 878 forks source link

Bug in user-bootstrap.sh: Incorrect Git Clone URL for Mininet #553

Closed Anshul-Johri-1 closed 6 months ago

Anshul-Johri-1 commented 6 months ago

While working on setting up the P4 tutorials environment, I encountered a bug in the user-bootstrap.sh at Line 17. The script attempts to clone the Mininet repository using the Git protocol, which results in a connection timeout error. Though it's only for historical reference, but it still needs to be corrected.

Bug:

git clone git://github.com/mininet/mininet mininet

Corrected Command:

git clone https://github.com/mininet/mininet mininet

Error Message Received

fatal: unable to connect to github.com:
github.com[0: 20.207.73.82]: errno=Connection timed out
AdarshRawat1 commented 6 months ago

@Anshul-Johri-1 Thank you for pointing that out.

jafingerhut commented 6 months ago

Fixed by PR #554