Correctly labeled tokens as 'op' for operators for consistency in calc.py

p4lang / tutorials

P4 language tutorials

Apache License 2.0

1.35k stars 886 forks source link

Correctly labeled tokens as 'op' for operators for consistency in calc.py #594

Closed Abhinavcode13 closed 5 months ago

Abhinavcode13 commented 5 months ago

Previously, the code appended the token with the num label (ts.append(Token('num', match.group(1)))). This would misrepresent the token, leading to confusion while differentiating between numbers and operators.
I changed it to ts.append(Token('op', match.group(1))) to ensure that the token is properly labelled as an operator.
Additionally, I've updated raise NumParseError to raise OpParseError to reflect the correct exception type.

Abhinavcode13 commented 5 months ago

Please review the linked PR, @jafingerhut.

jafingerhut commented 5 months ago

In this particular code, it appears that the type field of the Token object is initialized, but never used later in the code, so it doesn't appear like the bug would have caused any issues in the current code, but agreed it is nicer with your changes.