search

p4t5h3 / purebasic-language-for-sublime-text

PureBasic support for Sublime Text.
MIT License
4 stars 1 forks source link

Operators Fixes (#44) #47

Closed tajmone closed 2 years ago

tajmone commented 2 years ago

Move all operators definitions to independently named contexts, so that they might included according to context in the future.

Fix comparison operators RegEx to ensure that bi-character operators are captured as a single token, so that ligatures are shown correctly.

Amend capturing scope of logical operators from keyword.logical to keyword.operator.word.

Ensure that all operators RegExs include {{following_pointer}} in their definition, and add coverage tests for pointers following operators.

Update all operators tests accordingly.

tajmone commented 2 years ago

The build was failing due:

/home/runner/work/purebasic-language-for-sublime-text/purebasic-language-for-sublime-text/Data/Packages/PureBasic/Tests/syntax_test_comparison_operators.pb:1: unable to find SYNTAX TEST marker

I accidentally changed the letter casing of one char in the first line, but didn't notice it since the tests worked locally. Now I've amended and force pushed, so it should be fine now.

But even if I've force-pushed the amend it doesn't seem that the build is testing it again (Travis CI would re-run the tests when force pushing), so I have no idea how to run the tests again.

p4t5h3 commented 2 years ago

I am surprised I am allowed to push in a branch in our repository. Also I am used to the strict rule: reviewers do not change code but only request changes. But given the context I consider it acceptable to not be too strict here. 😊 This resolved the failing checks. In one test file the capitalization was still wrong.