gonzus
commented
8 years ago You are right, need to document and test these two. Thanks for bringing it to my attention, will do so presently.
Cheers!
On 04/07/2016 03:43, James E Keenan wrote:
Devel::QuickCover (i.e., lib/Devel/QuickCover.pm) source code contains two functions, set_output_directory() and set_metadata(), neither of which are documented.
[devel-quickcover] 34 $ ack set_output_directory. lib/Devel/QuickCover.pm 43:sub set_output_directory { [devel-quickcover] 35 $ ack set_metadata. lib/Devel/QuickCover.pm 50:sub set_metadata {
Nor are these functions exercised in your test suite (as I learned by running the distribution through Devel::Cover).
What purpose do they serve? If they should be used, they should be publicly documented and tested.
Thank you very much. Jim Keenan
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/p5pclub/devel-quickcover/issues/14, or mute the thread https://github.com/notifications/unsubscribe/AAMuohBvNc84NxxmQl6Ltu_azLH6faiHks5qSGVGgaJpZM4JD_vJ.
Devel::QuickCover (i.e., lib/Devel/QuickCover.pm) source code contains two functions, set_output_directory() and set_metadata(), neither of which are documented.
Nor are these functions exercised in your test suite (as I learned by running the distribution through Devel::Cover).
What purpose do they serve? If they should be used, they should be publicly documented and tested.
Thank you very much. Jim Keenan