p7zip-project / p7zip

A new p7zip fork with additional codecs and improvements (forked from https://sourceforge.net/projects/sevenzip/ AND https://sourceforge.net/projects/p7zip/).
765 stars 109 forks source link

[Q] fork status #114

Open biopsin opened 3 years ago

biopsin commented 3 years ago

Hi, I would like to package this fork for voidlinux, however I've being queried about

What makes this fork authoritative? This is doubly relevant because the homepage is still p7zip.sourceforge.net, but that site does not appear to direct people to the new fork.

and I'm in no position to answer the question, would you mind shed some light on this?

tracking https://github.com/void-linux/void-packages/pull/27953

teoberi commented 3 years ago

Hi, I would like to package this fork for voidlinux, however I've being queried about

What makes this fork authoritative? This is doubly relevant because the homepage is still p7zip.sourceforge.net, but that site does not appear to direct people to the new fork.

and I'm in no position to answer the question, would you mind shed some light on this?

tracking void-linux/void-packages#27953

https://github.com/jinfeihan57/p7zip/blob/master/README.md

This is the place for the active development of p7zip to include major modern codecs such as Brotli, Fast LZMA2, LZ4, LZ5, Lizard and Zstd

.

richarson commented 3 years ago

Since this project is using p7zip as a name for this fork, I'd say that in this case authoritative would be number 1, as otherwise @jinfeihan57 could be infringing copyrights/trademarks from the original developer.

IMHO and IANAL.

Edit: sorry @jloqfjgk, originally I replied to you as if you were this project's developer, I modified my original comment.

jinfeihan57 commented 3 years ago

The p7zip hasn't been updated since 2016 and I can't reach the author of the p7zip. Then I contacted Igor Pavlov, the author of the 7zip, who was unable to reach the author of the p7zip. So I discussed with the author of 7zip to re-update p7zip. This branch really didn't get authorization from the original author of p7zip (because he can't be reached). Anyone who can contact the author of p7zip please let me know. I'll talk to him about the authorization.

jinfeihan57 commented 3 years ago

The development information is in the readme and release description. The validity of authorization can only be determined after contacting the original author of p7zip. For code security and reliability, I will try to avoid bugs during development and perform a lot of tests. It also requires contributions from every user in the community (after all, I can't cover all the test environments). :)

jinfeihan57 commented 3 years ago

@jloqfjgk The ultimate goal of p7zip is to be the same as the 7zip version. I plan to complete the latest 19.00 update this year.

darealshinji commented 3 years ago

I must admit, I kinda underestimated the task. ^^"

Anyway, here's my opinion:

The fact that Pavlov doesn't provide a source repository or at least development snapshots every once in a while is really not helpful, indeed. If you really can't convince him to publish code that is more POSIX-friendly or at least easy to port with only a handful of patches, that means you're stuck with big diffs like you said. Maybe you can at least provide small patches to him, i.e. putting some #ifdef _WIN32 around some code which would otherwise compile fine.

Personally I would try to reduce the work as much as possible, at least for now. That means focusig on Linux and Mac, and avoiding extra code for platforms such as Haiku. I wouldn't really work on a GUI version. On Linux you normally use the available archiving GUI tool available from your desktop environment (i.e. engrampa, file-roller, ark?).

The question is if starting from scratch is more or less work than digging through the large diffs. To make the code easier to maintain in future it may help to put stuff such as POSIX-multithreading and Unix-specific CLI code to separate source files.

teoberi commented 3 years ago

7-Zip 21.00 alpha

The source code of new version and another additional packages will be released later after some testing period. What's new after 7-Zip 20.02 alpha: Some internal changes in code. ...

p7zip -> 7-Zip 19.00 -> 7-Zip 21.00 I don't know how you can keep up with 7-zip!

jinfeihan57 commented 3 years ago

@teoberi https://sourceforge.net/projects/sevenzip/files/7-Zip/ Since the author only discloses the source code of 7zip 19.00, it can only be updated to 19.00 at most. In fact, the author has released the binary installation package of 7zip20.00, but now 21.00 has been released, but the source code of 7zip20.00 has not yet been released. All of my updates are based on the source code of the 7zip version that the authors of the 7zip released.

darealshinji commented 3 years ago

[...] but the source code of 7zip20.00 has not yet been released.

Isn't that a violation to the LGPL? It's at least really sad, not very FOSS-like.

A note aside, I see that XZ Utils has at least a stable release from 2020 and an active public Git repository. Are there any other implementations of 7zip aside of the official 7zip releases and the POSIX port?

teoberi commented 3 years ago

What is this? https://sourceforge.net/p/sevenzip/discussion/45797/thread/d401ab2966/ https://sourceforge.net/p/sevenzip/discussion/45797/thread/cec5e63147/ 7-Zip for 64-bit Linux x86-64 (AMD64) -> The command line version of 7-Zip for Linux was released. Will there be a 7-Zip version for Linux?

teoberi commented 3 years ago

https://sourceforge.net/p/sevenzip/discussion/45797/thread/cec5e63147/#94e9/2017/0774

It's possible to merge 7-Zip code with p7zip compiler scripts.

jinfeihan57 commented 3 years ago

This is definitely a GOOD news. Now we just need to wait for the source code of 7zip-21.0 to be released. According to the source code, we can decide how to develop the next step.

teoberi commented 3 years ago

p7zip -> 7-Zip 19.00 -> 7-Zip 21.00 I don't know how you can keep up with 7-zip!

p7zip ->7-Zip for Linux 21.01

samoht0 commented 3 years ago

https://sourceforge.net/p/sevenzip/discussion/45797/thread/cec5e63147/ "Please write here, if you have some advices how to compile and link binaries that will work in most Linux systems." Unsure what's that aiming for. But doesn't look like supporting build from source.

ghost commented 3 years ago

Isn't that a violation to the LGPL? It's at least really sad, not very FOSS-like.

LGPL (and any open source licenses) only applies to redistributors of the software, original auther himself is not limited by such conditions, unless someone else is also contributing to the project (in that case, the original auther becomes a "redistributor" of that portion of the code) . However 7-Zip seems to be a one-man project, so I assume Igor Pavlov wrote everything and himself is not subject to any limitations - he can do whatever he want because it's his own work.

That been said, I notice that version 21.01 is still in alpha stage the latest stable release is version 19.00, so it is reasonable to stick with a well-tested stable version

sandsmark commented 3 years ago

for fun I split up all the changes in the stable version of 7zip since the last version I assumed it was synced with and started applying the patches.

these are the rest of the changes that might be interesting but don't apply cleanly/automatically: https://github.com/sandsmark/p7zip/tree/master/patches

fwiw, I assume it won't build etc., since I just did everything the stupid way and didn't update the cmakelists etc. but it took me less than an hour, and the changes aren't that complicated to apply (i. e. ignoring all the UI/Windows stuff, only importing the fixes and new codecs etc.)

wdlkmpx commented 3 years ago

It's really sad that 7zip is developed in a very awkward way

teoberi commented 3 years ago

Let's hope this can change after the sources for 7-Zip for Linux are published!

lilianmoraru commented 2 years ago

Source code is available, starting with 7-Zip 21.02