p7zip-project / p7zip

A new p7zip fork with additional codecs and improvements (forked from https://sourceforge.net/projects/sevenzip/ AND https://sourceforge.net/projects/p7zip/).
784 stars 108 forks source link

Extract 7za433_7zip_zstd.7z failed at alpine arm/v6(armhf) #187

Open ttionya opened 2 years ago

ttionya commented 2 years ago

Hello, @jinfeihan57

Apline 3.16 arm/v6 platform cannot find p7zip. Because the check does not pass, alpinelinux excludes builds for the arm/v6(armhf) platform.

Here is the issue of alpinelinux/aports, the error pipeline is here.

Extracting archive: 7za433_7zip_zstd.7z
Bus error (core dumped)
ERROR during : /builds/alpine/aports/main/p7zip/src/p7zip-17.04/check/../bin/7za x 7za433_7zip_zstd.7z
make: *** [makefile.common:101: test] Error 1
>>> ERROR: p7zip: check failed
wdlkmpx commented 2 years ago

Indeed, the alpine 3.16 armhf repository is missing p7zip

https://pkgs.alpinelinux.org/packages?name=p7zip&branch=v3.16&arch=armhf

p7zip in 3.15: https://pkgs.alpinelinux.org/packages?name=p7zip&branch=v3.15&arch=armhf

This is something that @ncopa should fix

antermin commented 2 years ago

From this commit, package build for p7zip is disabled on armhf due to a failed test.

ttionya commented 2 years ago

From this commit, package build for p7zip is disabled on armhf due to a failed test.

@antermin Yes, I created the issue in the alpinelinux repository. But I don't know when it will be fixed, or put on hold.

This issue should not be created here, I will close it later.

antermin commented 2 years ago

But I guess maybe it is OK to keep this issue open, because the failed test may indicate a bug in this fork (the test 7z file which uses the Zstd codec is failing):

Extracting archive: 7za433_7zip_zstd.7z
Bus error (core dumped)

You may also want to consider alternatives like using the upstream 7-Zip (Igor Pavlov added Linux support in 7-Zip some time ago) (the upstream does not support Zstd though), or try cielavenir's fork (which uses a more updated Zstd library version, and is rebased on upstream 7-Zip 22.00).

ttionya commented 2 years ago

I am also following this pipeline error. But I have no experience with C and I have not cared about 7z or zstd before, I am at my wits end.

There are no test cases in the cielavenir/p7zip, so I can't confirm if upgrading to p7zip 22 will solve the problem.

But I see that @jinfeihan57 is working on p7zip 22.0, and I expect it to be released soon.

jinfeihan57 commented 2 years ago

@ttionya Can zstd work on armhf?

ttionya commented 2 years ago

@jinfeihan57 ,

Sorry I don't know, I just know that it didn't pass the zstd decompression test on armhf, pipeline here.

jinfeihan57 commented 2 years ago

Can you try zstd v1.4.9 on your armhf device? I don't have armhf device.

ttionya commented 2 years ago

@jinfeihan57 ,

I don't have an armhf device either.

But I see that zstd was upgraded to v1.4.9 before the release of 17.04 wasn't it? So now the compiled program should be using zstd v1.4.9.

I cloned the master branch of this repository and compiled it on armhf Alpine 3.16 using GitHub Actions, the commands were obtained from the alpine repository and it took 2 hours to compile. Here is my test repository ttionya/p7zip-test, the wrong job is here, the excerpt of the error is as follows:

System ERROR:
E_FAIL
ERROR during : /app/check/../bin/7za a -t7z 7za433_7zip_zstd.7z 7za433_7zip_lzma -m0=zstd -mx=22
make: *** [makefile.common:101: test] Error 1