pBlueG / SA-MP-MySQL

MySQL plugin for San Andreas Multiplayer
BSD 3-Clause "New" or "Revised" License
196 stars 80 forks source link

issue with pawn.json for older versions of plugin #201

Open ADRFranklin opened 5 years ago

ADRFranklin commented 5 years ago

So older versions of the release packages do not follow the same folder structure as the newer ones do, and because of this sampctl users are not able to download/extract resources and this leaves them with an empty directory.

a possible fix is to change the regex to make the first folder in the release package optional so that older versions can be extracted properly.

(mysql-.+\\/)?plugins\\/mysql.so
(mysql-.+\\/)?plugins\\/mysql.dll

This has not been tested but should be enough to fix this.

Issues found on sampctl: https://github.com/Southclaws/sampctl/issues/258

maddinat0r commented 5 years ago

There's a lot of other things to consider:

I don't know how sampctl would handle some of these things, like missing files for example. But I think there's a lot more to change to make the R39-* releases work.

SysadminJeroen commented 5 years ago

The last version that CentOS 6 can use is R39-*.

And CentOS 6 uses MySQL, CentOS 7 uses MariaDB. Do keep that in mind.

And getting the dynamic .so to work was a pain in the ass, so I ended up using the statically linked one which I think I compiled myself.

ADRFranklin commented 5 years ago

Yeah, that is a lot of changes, and sampctl relies solely on your pawn.json for it to work.

I'll talk with Southclaws about a possible update that could allow you to specify a way to handle changes like seen here.