search

pBlueG / SA-MP-MySQL

MySQL plugin for San Andreas Multiplayer
BSD 3-Clause "New" or "Revised" License
196 stars 80 forks source link

just a cleanup of some useless crap #213

Open alextwothousand opened 5 years ago

alextwothousand commented 5 years ago

mysql auto_reconnects by default and there is no point saving player's data ongamemodeexit

maddinat0r commented 5 years ago

Thanks for the PR! Could you also do the same change in the login_system-cache.pwn file?

2Col commented 5 years ago

What about SetPlayerPos and SetPlayerFacingAngle in OnPlayerSpawn? If SetSpawnInfo is called before spawning player are those functions really necessary?

George480 commented 5 years ago

If I type exit in console, it does not call OnPlayerDisconnect but does call OnGameModeExit. Many servers do not use gmx but exit and start server up immediately.

What about SetPlayerPos and SetPlayerFacingAngle in OnPlayerSpawn? If SetSpawnInfo is called before spawning player are those functions really necessary?

What about the interior? Changing the interior after being spawned will still be too late and players will fall down.

alextwothousand commented 5 years ago

I will make these changes as soon as I get home. Thank you in advance.

Vladik01-11 commented 3 weeks ago

I will make these changes as soon as I get home. Thank you in advance.

There are rumors that he is still going home ðŸ«