search

pBouillon / ngx-flagr

🚩 Effortless feature flag management in Angular
https://pbouillon.github.io/ngx-flagr/
MIT License
9 stars 2 forks source link

Change the social card #32

Closed pBouillon closed 1 year ago

pBouillon commented 1 year ago

Issue Summary

The social card for the documentation project is still the one provided by default by docusaurus

When sharing a link, it should showcase a different image with ngx-flagr's icon instead

Category

- [ ] Bug report
- [ ] Regression
- [ ] Feature suggestion
- [x] Documentation issue
- [ ] Other

Expected Behavior

When sharing a link, it should showcase a different image with ngx-flagr's icon instead, using the colors of the docusaurus palette (the light one)

Something following this layout (same as the default one):

suggestion layout

Actual Behavior

The image that is used for the preview is the following (apps\docs-app\static\img\docusaurus-social-card.jpg):

docusaurus default

Steps to Reproduce

Environment

mintbomb27 commented 1 year ago

Hey! Can I work on this?

Also, would ngx-flagr's logo suit in the Docusaurus color palette? Should I change it to a red gradient?

pBouillon commented 1 year ago

Hey, sure, thanks for your help

It could be better to keep the colors consistent but I fear this will look "errory" having red everywhere, we can still give it a try!

mintbomb27 commented 1 year ago

Okay, Please take a look at https://www.figma.com/file/AAQ58ZY7lrijaGHYWeTdlY/ngx-flagr-card?type=design&node-id=0%3A1&mode=design&t=GCrBvjLXep2oYPMe-1

pBouillon commented 1 year ago

The last one is looking good! Could we keep the white background instead of a dark one (while still having the red gradient)?

Also, it might be out of scope but the "F" in the shield seems a bit off, is this just a feeling?

mintbomb27 commented 1 year ago

I've added a white bg one next to the dark one. Also, I've tried to create the logo again from scratch centering the F. If you think it looks better, I can replace with that.

pBouillon commented 1 year ago

That's awesome, thanks a lot!

Could we reduce the gradient width a bit? Also, without the dark background, the gradient on the title might not be necessary.

After that I think this will be perfect, we will just need to replace the logo for the readme/docs and the social card in the docs :smile:

EDIT: I also think that feature flag management is the part to be highlighted in the card since this is the goal of the library, not especially "effortless"

mintbomb27 commented 1 year ago

I've added two iterations. Let me know which one looks better.

pBouillon commented 1 year ago

I prefer the second one, with a smaller shade on the corner