search

pH-7 / eu-vat-validator

:moneybag: A simple and clean PHP library that validates EU VAT registration numbers against the central ec.europa.eu database (using the official europa API) :eu:
https://github.com/pH-7/eu-vat-validator
GNU General Public License v3.0
93 stars 17 forks source link

the throws annotation seems to be redundant #4

Closed hkwak closed 6 years ago

hkwak commented 6 years ago

https://github.com/pH-7/eu-vat-validator/blob/7f7b5517e95c83be532b0c27fef13836a090b5ef/src/Vat/Provider/Europa.php#L46

It looks like this getResource method will never throw SoapFault ( which is very good ) because it will be caught in line 57. In only throws the 'Exception' exception, so this annotation can be removed

pH-7 commented 6 years ago

Fixed in https://github.com/pH-7/eu-vat-validator/pull/5