search

pH200 / cycle-react

Rx functional interface to Facebook's React
MIT License
370 stars 18 forks source link

support RxJs5? #29

Closed franckXu closed 7 years ago

franckXu commented 8 years ago

support RxJs5?

I modified node_modules/rx/index.js require

var Rx = require('@reactivex/rxjs')
module.exports = Rx;

error log 

Uncaught TypeError: Object prototype may only be an Object or null: undefined
inherits @ inherits_browser.js:5
MakeReactRenderScheduler @ react-render-scheduler.js:13
(anonymous function) @ react-render-scheduler.js:109
vp2177 commented 7 years ago

Hi, just curious if RxJS v5 is supported now or whether support is planned?

pH200 commented 7 years ago

@vp2177 Hello, RxJS v5 is not supported currently. But, it shouldn't be difficult to support it right now comparing to last year's RxNext. I'll implement the adaptor for that.

pH200 commented 7 years ago

You can now find RxJS 5 support in branch rxjs https://github.com/pH200/cycle-react/tree/rxjs

I still have to change documentation and examples before publishing it. And notice that we may deprecate props.get with pluck.

vp2177 commented 7 years ago

Excellent, thank you! I'll give it a try. And I agree, pluck is the way to go.

pH200 commented 7 years ago

Implemented in v6.