search

pH7Software / pH7-Social-Dating-CMS

😻 pH7Builder (formerly pH7CMS) is a Professional & Open Source Social Dating CMS written in PHP 8 🚀 This Social Dating Script aims to be low resource-intensive, powerful and secure. pH7Builder includes over 40 modules. It is the first Professional, Free & Open Source Social Dating Site Builder Software and the first choice for enterprise level Da
https://pH7Builder.com
MIT License
972 stars 579 forks source link

Use Plyr for the HTML5 video player #641

Open pH-7 opened 5 years ago

pH-7 commented 5 years ago

It would be nice to use something like Plyr as an HTML5 media player for the "video" module.

https://github.com/pH7Software/pH7-Social-Dating-CMS/blob/master/_protected/app/system/core/classes/design/VideoDesignCore.php#L91-L95

Suggested Video Player Libraries

dimuller commented 5 years ago

Good idea! I will check it out. Thanks!

Undefined-Variables commented 4 years ago

Looks wonderful, going to make it happen for sure.

Undefined-Variables commented 4 years ago

This is not as difficult as you might think! The player already used is video.js which is the same base player that PLYr has been built upon!

There are two choices you can do this upgrade in the correct way, this means rewriting the api class in framework/video/api and then you can use a single script to return the video information if it’s embed and another for uploading and encoding!

This can be done like this as each services class has been standardised in PLYr.

All that’s left to do is write the script to control the remote player! This is best done using JSON key value pairs but it this seems like hard work you can take option 2...

https://GitHub.com/spaschen/Kirby-plytag

This was a plug-in for Kirby CMS HTML5video but works with PLYr flawlessly as it’s the exact same base video.js player used!

Personally I’m going with option 1. Almost fallen in love with the concept behind Rest API’s and the unlimited possibilities! Postman is a great tool too!

I will summit a pull when I have completed the script I just started! Player looks great and a huge upgrade on the most basic player I think I’ve ever seen!

Undefined-Variables commented 4 years ago

I have integrated Fluid_Player and it really does work well, also fully supports VAST :)

pH-7 commented 4 years ago

I have integrated Fluid_Player and it really does work well, also fully supports VAST :)

Really? how nice, that's amazing! Can't wait to see this! 🤗

Undefined-Variables commented 4 years ago

Yeah playing the videos isn't as hard as people think. The thing I have found to course me the most problems is conversion using ffmpeg as you have to think about a lot of formats that could be uploaded but likely never will be and quality plays a big role along side slight frame rate differences and sound too.

Think I have found a nice balance encoding with libx245 to h245 in 480, 720, 1080 and libfacc @ 96k. But 90% of video is 25fps but the odd device records at 30fps and this is a real headache for ffmpeg as its processed and thinks it was successful but in reality its jammed in the conversion queue stopping the process.

Once its perfect I will pull request :)

Undefined-Variables commented 4 years ago

1080 is not an exact science yet either its temperamental!