search

pKrime / Expy-Kit

Blending different Character Rigs together
352 stars 32 forks source link

Blender 2.7x compatibility, some overal improvements, different rigify versions metarigs support. #44

Closed mechanic-kharkiv closed 7 months ago

mechanic-kharkiv commented 7 months ago

It's for issue #45

mechanic-kharkiv commented 7 months ago

2b721ab - this was a tricky one. Docs lie, saying it works both on Bone, and PoseBone, but in fact, only in PoseBone. 8-O Anyway, now it works. Even on fingers. ;-)

mechanic-kharkiv commented 7 months ago

It's a little closer to be good enough to use. Next there must be some new presets. Maybe tonight.

mechanic-kharkiv commented 7 months ago

These 'x_4_0' presets are to convert to and from rigify 0.4 rigs (less spine bones, no face at all, different names).

mechanic-kharkiv commented 7 months ago

Thanks mate!

You're welcome. I'm just trying to fit it to my workflow. There might be more changes, because the workflow grows, and it demands more and more tools. And I like to torture my tools to the hilt, so sometimes they show their (usually) hidden weakest places. ;-)

pKrime commented 7 months ago

Hi, I have merged the current state of the request to avoid going through too many changes at once. Do you have an email so that we can write to each other, perhaps it's me but it looks like there are no DMs on github.

On a minor note, I see that you have added a module utils.py to sort out the differences between blender versions. It's ok and I don't blame "utils" as a name, but I think that something like version_compatibility.py would work better: utils is too generic.

Please feel free to suggest a name and use it in your future PRs if any, or I will change it when you'll be finished

Cheers, p.

mechanic-kharkiv commented 7 months ago

Hi, I have merged the current state of the request to avoid going through too many changes at once. Do you have an email so that we can write to each other, perhaps it's me but it looks like there are no DMs on github.

sure, I have email, I'll try to send it to you in minutes.

On a minor note, I see that you have added a module utils.py to sort out the differences between blender versions. It's ok and I don't blame "utils" as a name, but I think that something like version_compatibility.py would work better: utils is too generic. Please feel free to suggest a name and use it in your future PRs if any, or I will change it when you'll be finished

Agree. You're right, version_compatibility sounds good enough. I can refactor, and begin a new PR with this commit.

mechanic-kharkiv commented 7 months ago

I've sent an email to your gmail (possibly). If it didn't work, I'll invent a way to send it in a safe way.