search

pR0Ps / PhotoFloat

See https://git.zx2c4.com/PhotoFloat/ (this is a personal fork)
GNU General Public License v2.0
24 stars 2 forks source link

Refactor main walk in tree_walker #18

Closed mremallin closed 6 years ago

mremallin commented 6 years ago

Cleaned up the main walk

pR0Ps commented 6 years ago

Unfortunately using os.walk gets rid of the recursive nature of the walker. Using it means that top-level albums are fully parsed and dumped before their children. This means that they don't include the child album information in them, breaking the frontend. I played around with doing a depth-first walk but it didn't fix the issue.

I like the switch to the logging module and how functionality is more broken out into functions though so this is a good base for a walker rewrite.