search

pR0Ps / grafana-trackmap-panel

A panel for Grafana that visualizes GPS points as a line on an interactive map
https://grafana.com/plugins/pr0ps-trackmap-panel
Apache License 2.0
137 stars 61 forks source link

feature: option 'zoom with scroll wheel' #12

Closed aler9 closed 5 years ago

aler9 commented 5 years ago

One thing i like about Grafana is the ability to customize almost everything through options. This (really useful) plugin currently has a limited quantity of options, and i think adding more would constitute a significant improvement.

This PR allows the users to enable zooming with the scroll wheel, an hardcoded feature that can now be enabled or disabled at will. The option is disabled by default.

zsw

pR0Ps commented 5 years ago

Thanks for adding this! This plugin was initially developed for my own use cases so I didn't bother adding options but it could definitely use them.

I had a look at the diff and it seems like something went wrong when you force pushed. At the moment it's adding another "Autozoom" option to the panel. Could you fix that up?

aler9 commented 5 years ago

Hi, i was working on a big projects that makes use of Grafana to display GPS coordinates, and this plugin was really fit, it just needed a couple of additions.

I made the changes, check if now is better. I'll edit the other PR when this is merged, to avoid merge conflicts.

pR0Ps commented 5 years ago

@gswly: I rebased your commits on the current master. I also changed the way the setting was applied to the map so it wouldn't have to delete and re-create it when the setting was toggled.

Thanks again!