search

pWn3d1337 / Techguns

Techguns mod for minecraft
https://minecraft.curseforge.com/projects/techguns
16 stars 4 forks source link

[1.12.2] Console spam and some Exception #135

Open Vitali8 opened 6 years ago

Vitali8 commented 6 years ago

Hi, I have some spam in the server console. Server console are clogging up with errors, when you somehow interact with a mob (zombie, helicopter) from the mod. I tried to put a spawn on 0 in configs, but this doesn't solve the problem, because in some or other quantities the mobs continue to spawn.

Example error from console: Error

Also, sometimes there is such an Exception: Exception occurred during a PhaseState

pWn3d1337 commented 6 years ago

It's sponge throwing errors.

Vitali8 commented 6 years ago

@pWn3d1337, and this error too?

pWn3d1337 commented 6 years ago

It seems Sponge does not like techguns.

liach commented 6 years ago

@pWn3d1337 This is a techguns bug:

https://github.com/pWn3d1337/Techguns2/blob/0206e6c604b2a6e17379ee2b3ca059dc3c0596cf/src/main/java/techguns/items/armors/GenericArmor.java#L450-L480

You assert that armor wearers are always players, while all living entites can actually wear armor (zombies, armor stands, skeletons, etc.)

liach commented 6 years ago

More exactly, it is this line:

https://github.com/pWn3d1337/Techguns2/blob/0206e6c604b2a6e17379ee2b3ca059dc3c0596cf/src/main/java/techguns/items/armors/GenericArmor.java#L469

ProsperCraft commented 6 years ago

This is keeping mobs from having damage indicated ingame, from them dropping their loot, and working properly, can you please fix?