search

pa-m / sklearn

bits of sklearn ported to Go #golang
MIT License
345 stars 38 forks source link

Resolving the local path of the datasets using the build package #12

Closed VasanthakumarV closed 4 years ago

VasanthakumarV commented 4 years ago

When accessing the datasets in projects outside the GOPATH using go modules, the location of the datasets used in the package doesn't match the actual location where they get stored.

So I took inspiration from this post to arrive at a solution.

I am new to Go, if I made any obvious errors please do let me know I will try to correct them.

codecov[bot] commented 4 years ago

Codecov Report

Merging #12 into dev will decrease coverage by <.01%. The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #12      +/-   ##
==========================================
- Coverage   74.29%   74.28%   -0.01%     
==========================================
  Files          57       57              
  Lines        7659     7664       +5     
==========================================
+ Hits         5690     5693       +3     
- Misses       1618     1619       +1     
- Partials      351      352       +1
Impacted Files Coverage Δ
linear_model/Base.go 83.46% <100%> (ø) :arrow_up:
datasets/base.go 88.29% <87.5%> (-1.59%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc18cf6...c896fcf. Read the comment docs.

pa-m commented 4 years ago

nice. thanks!