search

pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
519 stars 63 forks source link

The defaults configuration is not properly recognized #110

Closed Ruluk closed 4 years ago

Ruluk commented 4 years ago

When defining the defaults config, any properties added should be sent to Pa11y, but they are not being sent.

The custom properties defined by Pa11y-CI, such as useIncognitoBrowserContext, work fine.

Steps to reproduce

  1. Define some pa11y properties inside the defaults configuration. For example: 
    {
"defaults": {
"runners": ["axe"],
"standard": "WCAG2A",
}
}
  2. Run Pa11y-CI
  3. The selected defaults will not be considered.

Related issues

I found some issues that may be related to the same bug: #107, #94, #90.

Ruluk commented 4 years ago

Please ignore this error. It was caused because I named the configuration property default instead of defaults. With the proper name, my tests work.

Sorry for the noisy issue!