pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
515 stars 63 forks source link

Option to generate a report without failing the tests #161

Closed hugohaggmark closed 10 months ago

hugohaggmark commented 2 years ago

We're using pa11y-ci as part of our CI. We use different threshold approaches depending on which branch the CI is building.

Is there a way to accomplish the latter scenario today in pa11y-ci?

If not, would you consider introducing a flag like dontFailOnErrors to make this flow possible?

Thank you 🙏

greggles commented 2 years ago

It seems like this is kind of a duplicate of #54.

I'm most familiar with Jenkins and can think of 2 solutions to this problem in Jenkins that might work in your context. You can use command || true so that when the command fails the exit code is hidden from the CI system. You can also use:

set +e
command-you-know-will-fail
set -e

This lets Jenkins keep running.

danyalaytekin commented 10 months ago

Hi both, we'll track this in #54 as @greggles has suggested. I imagine the suggested flag dontFailOnErrors will be inverted but this is good food for thought. Thanks!

danyalaytekin commented 10 months ago

Duplicate of #54