search

pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
515 stars 63 forks source link

pa11y-ci should use the puppeteer of pa11y #166

Closed masi closed 2 years ago

masi commented 2 years ago

Both packages have their own dependency on puppeteer. This causes npm to download puppeeteer once for pa11y and once for pa11y-cli.

At least that what happens to me when I have BackstopJS installed as well, which depends on a newer version of puppeteer (10.0.0 at the time of writing).

Sidenote: why does both packages do not depend on puppeteer-core? Then I could use any Chromium I want to.

josebolos commented 2 years ago

Pa11y-ci v3 now uses the same version of puppeteer than pa11y, so puppeteer will only be installed once.

Regarding the use of puppeteer-core, most of pa11y's usage happens in CI systems and we want to provide a tool that will work out of the box as much as possible. This also help us test pa11y releases and ensure that nothing will break if people choose to use a different Chromium version.