search

pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
515 stars 63 forks source link

global pa11y-ci configuration options hould not be part of "defaults" #167

Open masi opened 2 years ago

masi commented 2 years ago

Setting concurrency, reporters and basic puppeteer options like Chrome flags has IMHO nothing to do with per URL configuration options. IMHO they should be set outside of the "defaults" objects:

{
    'defaults': {
        'timeout': 1000,
        'viewport': {
            'width': 320,
            'height': 480
        },
    },
    'chromeLaunchConfig': {
        'args': ['--no-sandbox']
    },
    concurrency: 5
};

This would make the configuration more clear.

kant2002 commented 1 year ago

The problem even more interesting right now. I see inconsistency of the configuation pa11y and pa11y-ci.