search

pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
515 stars 63 forks source link

Update integration tests to support all platforms, including Windows #177

Closed aarongoldenthal closed 10 months ago

aarongoldenthal commented 2 years ago

This PR updates the integration tests to support all platforms, including Windows. The current integration tests fail on Windows for two reasons:

  1. The startWebsite function and JSON output tests rely on POSIX-style paths, so encounter errors when simply concatenated with Windows paths. The path.resolve or path.join functions are used instead.
  2. The cliCall function that executes the tests assumes the bin file is executable, which works in *nix systems, but is not true in Windows since it ignores the shebang. This function is updated to explicitly run the node command against the bin file.

This also adds Windows and Mac test cases to the GitHub Actions, matching https://github.com/pa11y/pa11y/pull/640.

danyalaytekin commented 10 months ago

Thanks again for this functionality @aarongoldenthal. The test runs have expired but, since it was previously approved, and nothing else has arrived in main since the time of approval, I'll merge it now, so I can build on it for pa11y-ci@4.